Redwood v6.0.0 Upgrade Guide

razzeee · September 13, 2023, 6:47am

It doesn’t seem like it’s fixed. The error is unchanged.

ahoopes16 · September 14, 2023, 7:32pm

Hey @gilliard I reported a slightly different bug that was causing infinite redirects, and I bet the fix for this will fix the logout infinite redirect as well. Just wanted you to know!

github.com/redwoodjs/redwood

[Bug?]: Routes infinitely redirect users after upgrading to Redwood v6

opened 06:13PM - 03 Sep 23 UTC

ahoopes16

bug/confirmed

### What's not working? Hello there, I started my project using Redwood v5, …and my routes are setup like this: ```javascript const Routes = () => { return ( <Router useAuth={useAuth}> <Route path="/" page={LoginPage} name="login" /> <Route path="/forgot-password" page={ForgotPasswordPage} name="forgotPassword" /> <Route path="/reset-password" page={ResetPasswordPage} name="resetPassword" /> <Route path="/verify" page={VerifyPage} name="verify" /> <Set private unauthenticated="login" wrap={MainLayout}> <Route path="/no-roles-assigned" page={NoRolesAssignedPage} name="noRolesAssigned" /> <Set private unauthenticated="noRolesAssigned" roles={[Role.Administrator, Role.Employee]}> <Private unauthenticated="admin" roles={Role.Employee}> {/** Employee Routes */} </Private> <Private unauthenticated="employee" roles={Role.Administrator}> {/** Administrator Routes */} </Private> </Set> </Set> <Route notfound page={NotFoundPage} /> </Router> ) } ``` While I was still using RedwoodJS v5, the `unauthenticated` and `roles` parameters worked exactly as expected. If a user was logged in with only the "Employee" or only the "Administrator" role, they could only access their respective routes, and if they tried to access one of the other roles' routes they would automatically get redirected to their pages. If a user was logged in but had no roles, they would be navigated to the No Roles Assigned Page. If a user was not logged in but tried to access any of the inner routes they would automatically get redirected to the login page. After upgrading to Redwood v6, if I try to access the `/employee` route without being logged in, it gets stuck in an infinite loop redirecting between `/employee` and `/admin`. Is there a different way that I need to organize these routes in Redwood v6 to get the same behavior I used to have? Or is this a true defect in how the routing is handled now? ### How do we reproduce the bug? It seems like as long as you have your routes in a similar configuration to the one that I posted above, you should run into this issue. 1. Have a "home" route that users can access without being authenticated 2. Have a `<Set private unauthenticated="home" />` set of routes 3. Have a route for when no roles are assigned to your authenticated users called `noRolesAssigned` inside the `Set` from step 2 4. Have a nested `<Set private unauthenticated="noRolesAssigned />` inside that first set 5. Inside the nested `Set`, add two `<Private />` components, one for each of 2 roles in your system 6. On each `Private` tag, add props that set the `roles` prop to one of the roles and then set the `unauthenticated` prop to a page inside the other `Private` tag 7. Without logging in, attempt to navigate to one of those `Private` routes 8. Observe the browser get locked up as it infinitely loops between the two rather than redirecting you to the `home` page ### What's your environment? (If it applies) ```shell System: OS: macOS 13.3.1 Shell: 5.9 - /bin/zsh Binaries: Node: 18.14.1 - /private/var/folders/v4/678lwd551ds0yz879_vvtdy40000gn/T/xfs-732c8753/node Yarn: 3.5.0 - /private/var/folders/v4/678lwd551ds0yz879_vvtdy40000gn/T/xfs-732c8753/yarn Databases: SQLite: 3.39.5 - /usr/bin/sqlite3 Browsers: Chrome: 116.0.5845.140 Edge: 116.0.1938.54 Safari: 16.4 npmPackages: @redwoodjs/auth-dbauth-setup: 6.1.0 => 6.1.0 @redwoodjs/core: 6.1.0 => 6.1.0 ``` ### Are you interested in working on this? - [ ] I'm interested in working on this

dom · September 15, 2023, 5:49pm

For anyone who was still experiencing issues with babel packages, I’ve released another patch. @razzeee tried it out as an RC and it seemed to solve the issues. Let me know if anyone is still experiencing the issues after this version:

dmasters19 · September 18, 2023, 8:06pm

We are getting an error trying to start storybook

Broken build, fix the error above

However, I don’t actually see any error that it’s referring to

info => Serving static files from ././public at /
info => Starting manager..
WARN unable to find package.json for @babel/cli
info Addon-docs: using MDX2
info => Using implicit CSS loaders
info => Using default Webpack5 setup
Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
99% end closing watch compilationWARN Force closed preview build

WARN Broken build, fix the error above.
WARN You may need to refresh the browser.

Command failed with exit code 1: yarn storybook dev --config-dir "node_modules/@redwoodjs/testing/config/storybook" --port 7910 --no-version-updates

PantheRedEye · September 18, 2023, 8:15pm

Hey David @dmasters19,

It looks like @dom may have addressed this here: [Bug?]: CLI unable to launch storybook · Issue #9198 · redwoodjs/redwood · GitHub

with the comment to try running yarn dedupe … does that help?

razzeee · September 19, 2023, 1:15pm

Latest version(s?) seems to have broken our data-migrate in docker. I’m still in the progress of figuring out, how it should work now.

Edit: Seems like running migrate once locally and checking in the changed package.json etc and changing my run.sh to use npx @redwoodjs/cli-data-migrate instead of rw data-migrate up

dom · September 19, 2023, 5:50pm

That’s right @razzeee sorry about that—I recently finished decoupling data migrate so that you could slim down your Dockerfile. data migrate is now a plugin like storybook and a standalone command so that you don’t have to bring in all Redwood’s hefty dev-time packages.

dom · September 19, 2023, 5:51pm

thanks @PantheRedEye! @dmasters19 do let me know if yarn dedupe works for you, and could you share what version you’re on?

dmasters19 · September 20, 2023, 5:08pm

Thanks, no luck with yarn dedupe though unfortunately. On version 6.1.0

klobetime · September 20, 2023, 10:05pm

I’m still seeing babel issues with v6.2.3:

$ yarn rw lint

Oops! Something went wrong! :(

ESLint: 8.49.0

ESLint couldn't find the plugin "@babel/eslint-plugin".

Backing up to RedwoodJS v6.1.1 without changing anything else restores linting.

dom · September 20, 2023, 11:15pm

Hey @klobetime, sorry that this bug’s a bit persistent. One thing I noticed about your output there is that the eslint version, 8.49.0, seems a bit off or at least not what I’d expect. Could you run yarn why on that one for me?

For example here’s what I see on v6.2.3:

redwood-app % yarn why eslint
├─ @redwoodjs/eslint-config@npm:6.2.3
│  └─ eslint@npm:8.46.0 (via npm:8.46.0)
│
└─ @redwoodjs/eslint-plugin@npm:6.2.3
   └─ eslint@npm:8.46.0 (via npm:8.46.0)

klobetime · September 21, 2023, 12:39am

Nice catch. I see:

$ yarn why eslint
├─ @redwoodjs/eslint-config@npm:6.3.0
│  └─ eslint@npm:8.46.0 (via npm:8.46.0)
│
├─ @redwoodjs/eslint-plugin@npm:6.3.0
│  └─ eslint@npm:8.46.0 (via npm:8.46.0)
│
└─ discovery@workspace:.
   └─ eslint@npm:8.49.0 (via npm:^8.45.0)

I changed our project package.json inclusion to be “=8.46.0” to lock the versions down to a match and was able to run yarn rw lint with no issues. So it looks like either the version mismatch or something in the newer eslint is the culprit here. To be clear, our setup worked fine in RedwoodJS v6.1.1 with eslint v8.48.0.

So back in the fold – thank you!

tilmannb · September 27, 2023, 7:29am

Hello all,

upgraded from 5.* to 6.3.1. First: Thanks again to the team for the extraordinary work!

I have two problems:

1. Using a useLocation hook without an identified user I see this error message:

2. I am seeing this error while prerendering.

Error: @pentelemetry/api: Attempted duplicate registration of API: trace

But RW seems to prerender the route none the less.

Any ideas how to get rid of this error message?

Error: @opentelemetry/api: Attempted duplicate registration of API: trace
    at registerGlobal (/github/workspace/node_modules/@opentelemetry/api/src/internal/global-utils.ts:47:17)
    at TraceAPI.setGlobalTracerProvider (/github/workspace/node_modules/@opentelemetry/api/src/api/trace.ts:67:35)
    at TraceAPI.api.trace.setGlobalTracerProvider (/github/workspace/node_modules/diagnostic-channel-publishers/dist/src/azure-coretracing.pub.js:72:58)
    at BasicTracerProvider.register (/github/workspace/node_modules/@opentelemetry/sdk-trace-base/src/BasicTracerProvider.ts:153:11)
    at Object.azureCoreTracingPatchFunction [as patch] (/github/workspace/node_modules/diagnostic-channel-publishers/dist/src/azure-coretracing.pub.js:74:29)
    at Module.patchedRequire [as require] (/github/workspace/node_modules/diagnostic-channel/dist/src/patchRequire.js:51:52)
    at require (node:internal/modules/cjs/helpers:121:18)
    at Object.<anonymous> (/github/workspace/node_modules/applicationinsights/node_modules/@azure/core-rest-pipeline/dist/index.js:12:19)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._compile (/github/workspace/node_modules/pirates/lib/index.js:136:24)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Object.newLoader [as .js] (/github/workspace/node_modules/pirates/lib/index.js:141:7)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Function.Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at Module.patchedRequire [as require] (/github/workspace/node_modules/diagnostic-channel/dist/src/patchRequire.js:16:46)
    at require (node:internal/modules/cjs/helpers:121:18)
    at Object.<anonymous> (/github/workspace/node_modules/applicationinsights/Library/AuthorizationHandler.ts:4:1)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._compile (/github/workspace/node_modules/pirates/lib/index.js:136:24)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Object.newLoader [as .js] (/github/workspace/node_modules/pirates/lib/index.js:141:7)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Function.Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at Module.patchedRequire [as require] (/github/workspace/node_modules/diagnostic-channel/dist/src/patchRequire.js:16:46)
    at require (node:internal/modules/cjs/helpers:121:18)
    at Object.<anonymous> (/github/workspace/node_modules/applicationinsights/Library/TelemetryClient.ts:5:1)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._compile (/github/workspace/node_modules/pirates/lib/index.js:136:24)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Object.newLoader [as .js] (/github/workspace/node_modules/pirates/lib/index.js:141:7)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Function.Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at Module.patchedRequire [as require] (/github/workspace/node_modules/diagnostic-channel/dist/src/patchRequire.js:16:46)
    at require (node:internal/modules/cjs/helpers:121:18)
    at Object.<anonymous> (/github/workspace/node_modules/applicationinsights/Library/NodeClient.ts:3:1)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._compile (/github/workspace/node_modules/pirates/lib/index.js:136:24)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Object.newLoader [as .js] (/github/workspace/node_modules/pirates/lib/index.js:141:7)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Function.Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at Module.patchedRequire [as require] (/github/workspace/node_modules/diagnostic-channel/dist/src/patchRequire.js:16:46)
    at require (node:internal/modules/cjs/helpers:121:18)
    at Object.<anonymous> (/github/workspace/node_modules/applicationinsights/applicationinsights.ts:20:1)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._compile (/github/workspace/node_modules/pirates/lib/index.js:136:24)
Error: @opentelemetry/api: Attempted duplicate registration of API: propagation
    at registerGlobal (/github/workspace/node_modules/@opentelemetry/api/src/internal/global-utils.ts:47:17)
    at PropagationAPI.setGlobalPropagator (/github/workspace/node_modules/@opentelemetry/api/src/api/propagation.ts:67:26)
    at BasicTracerProvider.register (/github/workspace/node_modules/@opentelemetry/sdk-trace-base/src/BasicTracerProvider.ts:163:19)
    at Object.azureCoreTracingPatchFunction [as patch] (/github/workspace/node_modules/diagnostic-channel-publishers/dist/src/azure-coretracing.pub.js:74:29)
    at Module.patchedRequire [as require] (/github/workspace/node_modules/diagnostic-channel/dist/src/patchRequire.js:51:52)
    at require (node:internal/modules/cjs/helpers:121:18)
    at Object.<anonymous> (/github/workspace/node_modules/applicationinsights/node_modules/@azure/core-rest-pipeline/dist/index.js:12:19)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._compile (/github/workspace/node_modules/pirates/lib/index.js:136:24)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Object.newLoader [as .js] (/github/workspace/node_modules/pirates/lib/index.js:141:7)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Function.Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at Module.patchedRequire [as require] (/github/workspace/node_modules/diagnostic-channel/dist/src/patchRequire.js:16:46)
    at require (node:internal/modules/cjs/helpers:121:18)
    at Object.<anonymous> (/github/workspace/node_modules/applicationinsights/Library/AuthorizationHandler.ts:4:1)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._compile (/github/workspace/node_modules/pirates/lib/index.js:136:24)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Object.newLoader [as .js] (/github/workspace/node_modules/pirates/lib/index.js:141:7)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Function.Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at Module.patchedRequire [as require] (/github/workspace/node_modules/diagnostic-channel/dist/src/patchRequire.js:16:46)
    at require (node:internal/modules/cjs/helpers:121:18)
    at Object.<anonymous> (/github/workspace/node_modules/applicationinsights/Library/TelemetryClient.ts:5:1)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._compile (/github/workspace/node_modules/pirates/lib/index.js:136:24)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Object.newLoader [as .js] (/github/workspace/node_modules/pirates/lib/index.js:141:7)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Function.Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at Module.patchedRequire [as require] (/github/workspace/node_modules/diagnostic-channel/dist/src/patchRequire.js:16:46)
    at require (node:internal/modules/cjs/helpers:121:18)
    at Object.<anonymous> (/github/workspace/node_modules/applicationinsights/Library/NodeClient.ts:3:1)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._compile (/github/workspace/node_modules/pirates/lib/index.js:136:24)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Object.newLoader [as .js] (/github/workspace/node_modules/pirates/lib/index.js:141:7)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Function.Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at Module.patchedRequire [as require] (/github/workspace/node_modules/diagnostic-channel/dist/src/patchRequire.js:16:46)
    at require (node:internal/modules/cjs/helpers:121:18)
    at Object.<anonymous> (/github/workspace/node_modules/applicationinsights/applicationinsights.ts:20:1)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._compile (/github/workspace/node_modules/pirates/lib/index.js:136:24)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)

dmasters19 · September 27, 2023, 6:52pm

Getting this error on 6.3.1 with storybook

ModuleBuildError: Module build failed (from ../node_modules/resolve-url-loader/index.js):
Error: resolve-url-loader: error processing CSS
  a valid source-map is not present (ensure preceding loaders output a source-map)
  at file:///Users/davidmasters/workspace/banquethealth/node_modules/primeicons/primeicons.css:4:5
    at encodeError (/Users/davidmasters/workspace/banquethealth/node_modules/resolve-url-loader/index.js:274:12)
    at onFailure (/Users/davidmasters/workspace/banquethealth/node_modules/resolve-url-loader/index.js:215:14)
    at processResult (/Users/davidmasters/workspace/banquethealth/node_modules/webpack/lib/NormalModule.js:764:19)
    at /Users/davidmasters/workspace/banquethealth/node_modules/webpack/lib/NormalModule.js:866:5
    at /Users/davidmasters/workspace/banquethealth/node_modules/loader-runner/lib/LoaderRunner.js:400:11
    at /Users/davidmasters/workspace/banquethealth/node_modules/loader-runner/lib/LoaderRunner.js:252:18
    at context.callback (/Users/davidmasters/workspace/banquethealth/node_modules/loader-runner/lib/LoaderRunner.js:124:13)
    at onFailure (/Users/davidmasters/workspace/banquethealth/node_modules/resolve-url-loader/index.js:215:5)

WARN Broken build, fix the error above.
WARN You may need to refresh the browser.

Josh-Walker-GM · September 28, 2023, 6:10am

Hey @tilmannb, thanks for highlighting these! I’ll try to take a look at replicating the second issue you’re facing and I’ll get back to you about what I find and any possible fixes. Sorry in advance that it might take a number of days to get to this - we’re currently running our first in-person conference so it’s a busy time for the team right now.

klobetime · October 2, 2023, 5:40pm

We see the same thing running v6.3.1.

deep-randhawa · October 4, 2023, 1:51am

Hi, while upgrading I’m getting this error

gen | Node.js v18.14.1
gen | yarn rw-gen-watch exited with code 1
web | 6:50:37 PM [vite] http proxy error at /cubeToken:
web | Error: connect ECONNREFUSED ::1:8911
web |     at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1494:16)
web | 6:50:37 PM [vite] http proxy error at /cubeToken:
web | Error: connect ECONNREFUSED ::1:8911
web |     at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1494:16)
web | 6:50:38 PM [vite] http proxy error at /graphql:
web | Error: connect ECONNREFUSED ::1:8911
web |     at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1494:16)
web | 6:50:38 PM [vite] http proxy error at /graphql:
web | Error: connect ECONNREFUSED ::1:8911
web |     at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1494:16)

Any ideas what could be going on or how to debug this? The server is not starting up basically but unclear why

So it fails on 2 of my endpoints, but none of the GQL endpoints ever come live actually.

Tobbe · October 4, 2023, 4:15pm

Have you made sure nothing else is running on that port?
Also, have you tried launching just the api side?
Have you tried both yarn rn dev and yarn rw serve?

deep-randhawa · October 4, 2023, 4:19pm

Yes. Unfortunately yarn rw serve also fails, but on the logger. I wonder if this might be the reason the server is not starting up in my initial post either.

➜  platform git:(feat/redwoodjs-upgrade) ✗ yarn rw serve 
Starting API and Web Servers...
Loading server config from /Users/agriful/Developer/platform/api/server.config.js 

Importing Server Functions... 
/healthz 0 ms
Took 135 ms
Web server started on http://localhost:8910
API serving from http://localhost:8910
API listening on http://localhost:8910/.redwood/functions/
GraphQL endpoint at /.redwood/functions/graphql
/Users/agriful/Developer/platform/node_modules/@redwoodjs/api/dist/logger/index.js:274
      config.db.$on(level, event => {
                ^

TypeError: config.db.$on is not a function
    at /Users/agriful/Developer/platform/node_modules/@redwoodjs/api/dist/logger/index.js:274:17
    at Array.forEach (<anonymous>)
    at handlePrismaLogging (/Users/agriful/Developer/platform/node_modules/@redwoodjs/api/dist/logger/index.js:259:21)
    at Object.<anonymous> (/Users/agriful/Developer/platform/api/dist/lib/db.js:54:39)
    at Module._compile (node:internal/modules/cjs/loader:1254:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)
    at Module.load (node:internal/modules/cjs/loader:1117:32)
    at Module._load (node:internal/modules/cjs/loader:958:12)
    at Module.require (node:internal/modules/cjs/loader:1141:19)
    at require (node:internal/modules/cjs/helpers:110:18)

Node.js v18.14.1
➜  platform git:(feat/redwoodjs-upgrade) ✗

Tobbe · October 4, 2023, 4:21pm

Hmm, someone else was also having problems with $ functions on the db object. Something about client extensions… I’ll see if I can find it. But feel free to look around for yourself too. Not sure if it’ll actually help or not though.